Hi, On 5/3/21 5:46 PM, Hans de Goede wrote: > The Type-C connector on these devices is connected to DP-2 not DP-1, > so the reference must be to the DD04 child-node of the GPU, rather > then the DD02 child-node. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> Since this is pretty much independent from the rest of the series, I'll take this upstream through the pdx86 tree. I've added this to my review-hans branch now, and it will get added to for-next from there. Regards, Hans > --- > drivers/platform/x86/intel_cht_int33fe_typec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel_cht_int33fe_typec.c b/drivers/platform/x86/intel_cht_int33fe_typec.c > index b61bad9cc8d2..d59544167430 100644 > --- a/drivers/platform/x86/intel_cht_int33fe_typec.c > +++ b/drivers/platform/x86/intel_cht_int33fe_typec.c > @@ -168,8 +168,8 @@ static int cht_int33fe_setup_dp(struct cht_int33fe_data *data) > return -ENODEV; > } > > - /* Then the DP child device node */ > - data->dp = device_get_named_child_node(&pdev->dev, "DD02"); > + /* Then the DP-2 child device node */ > + data->dp = device_get_named_child_node(&pdev->dev, "DD04"); > pci_dev_put(pdev); > if (!data->dp) > return -ENODEV; >