Hi,
On 5/3/21 10:00 AM, Heikki Krogerus wrote:
> Hi Hans,
>
> On Wed, Apr 28, 2021 at 11:52:52PM +0200, Hans de Goede wrote:
>> +/**
>> + * struct drm_connector_oob_hotplug_event_data: OOB hotplug event data
>> + *
>> + * Contains data about out-of-band hotplug events, signalled through
>> + * drm_connector_oob_hotplug_event().
>> + */
>> +struct drm_connector_oob_hotplug_event_data {
>> + /**
>> + * @connected: New connected status for the connector.
>> + */
>> + bool connected;
>> + /**
>> + * @dp_lanes: Number of available displayport lanes, 0 if unknown.
>> + */
>> + int dp_lanes;
>> + /**
>> + * @orientation: Connector orientation.
>> + */
>> + enum typec_orientation orientation;
>> +};
>
> I don't think the orientation is relevant. It will always be "normal"
> from DP PoW after muxing, no?
That is what I thought to, but during the discussion of my previous attempt
at this one of the i915 devs mentioned that in some cases the muxes manage
to swap the lane order when the connector upside-down and at least the
Intel GPUs can correct for this on the GPU side, so they asked for this
info to be included.
> I'm also not sure those deatils are enough in the long run. Based on
> what I've understood from our graphics team guys, for example knowing
> if multi-function is preferred may be important in some cases.
The current data being passed is just intended as a starting point,
this is purely a kernel internal API so we can easily add more
data to the struct. As I mentioned in the cover-letter the current
oob_hotplug handler which the i915 patch adds to the i915 driver does
not actually do anything with the data. ATM it is purely there to
demonstrate that the ability to pass relevant data is there now
(which was an issue with the previous attempt). I believe the current
code is fine as a PoC of "pass event data" once GPU drivers actually
start doing something with the data we can extend or outright replace
it without issues.
> +Imre.
>
> All of that, and more, is already available in the Configuration VDO
> Status VDO that the we have negotiated with the DP partner. Both those
> VDOs are part of struct typec_displayport_data. I think we should
> simply supply that structure to the DRM code instead of picking those
> details out of it...
I'm not sure I like the idea of passing the raw VDO, but if the
DRM folks think that would be useful we can certainly add it.
Regards,
Hans
>
>> /**
>> * struct drm_tv_connector_state - TV connector related states
>> * @subconnector: selected subconnector
>> @@ -1110,6 +1132,15 @@ struct drm_connector_funcs {
>> */
>> void (*atomic_print_state)(struct drm_printer *p,
>> const struct drm_connector_state *state);
>> +
>> + /**
>> + * @oob_hotplug_event:
>> + *
>> + * This will get called when a hotplug-event for a drm-connector
>> + * has been received from a source outside the display driver / device.
>> + */
>> + void (*oob_hotplug_event)(struct drm_connector *connector,
>> + struct drm_connector_oob_hotplug_event_data *data);
>
> So I would not try to generalise this like that. This callback should
> be USB Type-C DP altmode specific:
>
> void (*oob_hotplug_event)(struct drm_connector *connector,
> struct typec_displayport_data *data);
>
> Or like this if the orientation can really be reversed after muxing:
>
> void (*oob_hotplug_event)(struct drm_connector *connector,
> struct typec_altmode *altmode,
> struct typec_displayport_data *data);
>
> You can now check the orientation separately with
> typec_altmode_get_orientation() if necessary.
>
>
> thanks,
>
