Hi,
On 4/19/21 4:31 PM, Hans de Goede wrote:
> Change the type of ret form a size_t to a ssize_t, matching the prototype
> of simple_write_to_buffer(), fixing this warning reported by smatch:
>
> drivers/platform/x86/intel_pmc_core.c:1369 pmc_core_lpm_latch_mode_write() warn: unsigned 'ret' is never less than zero.
>
> Fixes: 8074a79fad2e ("platform/x86: intel_pmc_core: Add option to set/clear LPM mode")
> Cc: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
I've applied this to my review-hans branch now.
Regards,
Hans
> ---
> drivers/platform/x86/intel_pmc_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> index 3ae00ac85c75..d174aeb492e0 100644
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -1360,7 +1360,7 @@ static ssize_t pmc_core_lpm_latch_mode_write(struct file *file,
> struct pmc_dev *pmcdev = s->private;
> bool clear = false, c10 = false;
> unsigned char buf[8];
> - size_t ret;
> + ssize_t ret;
> int idx, m, mode;
> u32 reg;
>
>
