Re: [External] Re: [PATCH] platform/x86: thinkpad_acpi: Correct thermal sensor allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Hans

On 13/04/2021 02:28, Hans de Goede wrote:
> Hi,
> 
> On 4/7/21 11:20 PM, Mark Pearson wrote:
>> On recent Thinkpad platforms it was reported that temp sensor 11 was
>> always incorrectly displaying 66C. It turns out the reason for this is
>> that this location in EC RAM is not a temperature sensor but is the
>> power supply ID (offset 0xC2).
>>
>> Based on feedback from the Lenovo firmware team the EC RAM version can
>> be determined and for the current version (3) only the 0x78 to 0x7F
>> range is used for temp sensors. I don't have any details for earlier
>> versions so I have left the implementation unaltered there.
>>
>> Note - in this block only 0x78 and 0x79 are officially designated (CPU &
>> GPU sensors). The use of the other locations in the block will vary from
>> platform to platform; but the existing logic to detect a sensor presence
>> holds.
>>
>> Signed-off-by: Mark Pearson <markpearson@xxxxxxxxxx>
> 
> I've merged this, note I've added one small fixup to initialize ver to
> 0 when it is declared, also see a remark inline below.
> 

Agreed on setting ver to zero - thanks for adding that

Mark




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux