On Mo, 2021-04-12 at 12:43 +0300, Andy Shevchenko wrote: > > On Mon, Apr 12, 2021 at 12:29 PM Steffen Dirkwinkel > <linux-kernel-dev@xxxxxxxxxxxx> wrote: > > > > From: Steffen Dirkwinkel <s.dirkwinkel@xxxxxxxxxxxx> > > > > pmc_plt_clk* clocks are used for ethernet controllers so need to stay > > turned on. This adds the affected board family to critclk_systems DMI > > table so the clocks are marked as CLK_CRITICAL and not turned off. > > > > This replaces the previosly listed boards with a match for the whole > > "...previously..." thanks > > > device family. There are new affected boards that would otherwise need > > to be listed. There are only few unaffected boards in the family and > > "...only a few..." will drop the phrase > > > having the clocks turned on is not an issue on those. > > "...not an issue." Not an issue for these industrial PCs as sleep is an unusual use case. Having no ethernet after boot/sleep is worse. > > > Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL") > > Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@xxxxxxxxxxxx> > > I'm afraid it's a bit too much. Is there any guarantee all the boards > based on x86 will be Baytrail only? > Sorry, I guess I should make this clearer in the message. All boards with "CBxx63" are Baytrail. > -- > With Best Regards, > Andy Shevchenko > Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075