Hi, On 3/23/21 10:01 PM, Luca Stefani wrote: > * On recent ZenBooks the fn-lock is disabled > by default on boot while running Windows. > > * Add a module param ( fnlock_default ) that allows > changing the default at probe time > > Signed-off-by: Luca Stefani <luca.stefani.ge1@xxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/asus-wmi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index 9ca15f724343..ebaeb7bb80f5 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -47,6 +47,9 @@ MODULE_AUTHOR("Corentin Chary <corentin.chary@xxxxxxxxx>, " > MODULE_DESCRIPTION("Asus Generic WMI Driver"); > MODULE_LICENSE("GPL"); > > +static bool fnlock_default = true; > +module_param(fnlock_default, bool, 0444); > + > #define to_asus_wmi_driver(pdrv) \ > (container_of((pdrv), struct asus_wmi_driver, platform_driver)) > > @@ -2673,7 +2676,7 @@ static int asus_wmi_add(struct platform_device *pdev) > err = asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT, 2, NULL); > > if (asus_wmi_has_fnlock_key(asus)) { > - asus->fnlock_locked = true; > + asus->fnlock_locked = fnlock_default; > asus_wmi_fnlock_update(asus); > } > >
