Hi,
On 3/23/21 9:25 PM, Luca Stefani wrote:
> * On recent ZenBooks the fn-lock is disabled
> by default on boot while running Windows.
>
> * Add a module param ( fnlock_default ) that allows
> changing the default at probe time
>
> Signed-off-by: Luca Stefani <luca.stefani.ge1@xxxxxxxxx>
> ---
> drivers/platform/x86/asus-wmi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 9ca15f724343..f3ed72f01462 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -47,6 +47,9 @@ MODULE_AUTHOR("Corentin Chary <corentin.chary@xxxxxxxxx>, "
> MODULE_DESCRIPTION("Asus Generic WMI Driver");
> MODULE_LICENSE("GPL");
>
> +static bool fnlock_default = false;
The initial value of this needs to be true, so that there is no behavioral
change when people upgrade from a kernel without this to one with it.
And then people who want a different behavior can get that by setting
the module option.
Regards,
Hans
> +module_param(fnlock_default, bool, 0444);
> +
> #define to_asus_wmi_driver(pdrv) \
> (container_of((pdrv), struct asus_wmi_driver, platform_driver))
>
> @@ -2673,7 +2676,7 @@ static int asus_wmi_add(struct platform_device *pdev)
> err = asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT, 2, NULL);
>
> if (asus_wmi_has_fnlock_key(asus)) {
> - asus->fnlock_locked = true;
> + asus->fnlock_locked = fnlock_default;
> asus_wmi_fnlock_update(asus);
> }
>
>
