Hi,
On 3/16/21 11:17 PM, Luca Stefani wrote:
> * On recent ZenBooks the fn-lock is disabled
> by default on boot while running Windows.
>
> * Follow the same paradigm also here.
>
> Signed-off-by: Luca Stefani <luca.stefani.ge1@xxxxxxxxx>
This will be a behavioral change for many users where their F-keys will
now all of a sudden work different after boot under Linux then they
did before.
As such this seems like a bad idea, so I'm not going to merge this patch.
What might be an option is adding a module-option which allows users to
configure the default setting at boot that way, while keeping the current
default.
Regards,
Hans
> ---
> drivers/platform/x86/asus-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 9ca15f724343..32319f7d6e17 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -2673,7 +2673,7 @@ static int asus_wmi_add(struct platform_device *pdev)
> err = asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT, 2, NULL);
>
> if (asus_wmi_has_fnlock_key(asus)) {
> - asus->fnlock_locked = true;
> + asus->fnlock_locked = false;
> asus_wmi_fnlock_update(asus);
> }
>
>
