Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pierre:
Thanks for your review!
On 2021/3/8 23:59, Pierre-Louis Bossart wrote:



   module_param(force_rfkill, bool, 0444);
   MODULE_PARM_DESC(force_rfkill, "enable rfkill on non whitelisted
models");

+

spurious line change
I just want to make them separate with more space .
If it cause concern, I will remote the line in V5.

it's fine to improve spaces/alignment, just do it in a separate patch.



   static const struct dmi_system_id dell_device_table[] __initconst = {
       {
           .ident = "Dell laptop",
@@ -2205,11 +2209,17 @@ static int __init dell_init(void)
       dell_laptop_register_notifier(&dell_laptop_notifier);

       if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) &&
-        dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) {
-        micmute_led_cdev.brightness =
ledtrig_audio_get(LED_AUDIO_MICMUTE);
-        ret = led_classdev_register(&platform_device->dev,
&micmute_led_cdev);
-        if (ret < 0)
-            goto fail_led;
+
    dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) {

not sure why you changed the alignment?
The previous alignment is a little not correct.
So I adjust it
If it cause concern, will restore it to original shape.

same here, use a different patch.

As you suggested,I should add the alignment change in another patch.
But if i keep the old alignment, the code will be very odd.
Seems like that I have to change the below code to new alignment in this patch.

if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) &&
    dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) { <<--- changed back
	if (!privacy_valid)
	    	has_privacy = true;
	else
	    	has_privacy = false;
	if (!has_privacy) {
		micmute_led_cdev.brightness <<----------- new alignment
		...
	}
...
}





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux