[PATCH v2 0/7] platform/x86: dell-wmi-sysman: Various error-handling and robustness fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi All,

There have been several bug-reports about crashes related to the
dell-wmi-sysman module:

https://bugzilla.redhat.com/show_bug.cgi?id=1936171
https://bugzilla.kernel.org/show_bug.cgi?id=211895
https://bugs.archlinux.org/task/69702

Here is v2 of my series with a bunch of fixes for NULL pointer derefs,
double-frees, etc. which fixes this.

New in v2:
-New patch: "platform/x86: dell-wmi-sysman: Fix crash caused by calling 
kset_unregister twice" which addresses the direct-cause of
the crash.  Note that the crash was already fixed in v1 because
that removed the code-path where kset_unregister ended up being
called twice.

-Dropped: "platform/x86: dell-wmi-sysman: Make init_bios_attributes() 
ACPI object parsing more robust". This needs more testing / discussion
and is not necessary to fix the boot-failure which people are seeing.

Regards,

Hans


Hans de Goede (7):
  platform/x86: dell-wmi-sysman: Fix crash caused by calling
    kset_unregister twice
  platform/x86: dell-wmi-sysman: Fix possible NULL pointer deref on exit
  platform/x86: dell-wmi-sysman: Make it safe to call
    exit_foo_attributes() multiple times
  platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting
    called twice on init_bios_attributes() failure
  platform/x86: dell-wmi-sysman: Cleanup sysman_init() error-exit
    handling
  platform/x86: dell-wmi-sysman: Make sysman_init() return -ENODEV of
    the interfaces are not found
  platform/x86: dell-wmi-sysman: Cleanup
    create_attributes_level_sysfs_files()

 .../dell/dell-wmi-sysman/enum-attributes.c    |  3 +
 .../x86/dell/dell-wmi-sysman/int-attributes.c |  3 +
 .../dell/dell-wmi-sysman/passobj-attributes.c |  3 +
 .../dell/dell-wmi-sysman/string-attributes.c  |  3 +
 .../x86/dell/dell-wmi-sysman/sysman.c         | 84 +++++++------------
 5 files changed, 44 insertions(+), 52 deletions(-)

-- 
2.30.2




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux