On 18/03/2021 08:17, Hans de Goede wrote:
> Hi,
>
> On 3/11/21 6:48 PM, Mark Pearson wrote:
>> Lenovo platforms with DYTC versions earlier than version 5 don't set
>> the lapmode interface correctly, causing issues with thermald on
>> older platforms.
>>
>> Add checking to only create the dytc_lapmode interface for version
>> 5 and later.
>>
>> Signed-off-by: Mark Pearson <markpearson@xxxxxxxxxx>
>
> I've added a:
>
> Fixes: 1ac09656bded ("platform/x86: thinkpad_acpi: Add palm sensor support")
>
> Tag, this will help with the patch automatically getting selected for
> stable kernel-series which contain the patch pointed to by the Fixes: tag.
>
> In this case this won't work since this patch seems to depend on code
> introduced in:
>
> commit c3bfcd4c676238 ("platform/x86: thinkpad_acpi: lap or desk mode interface")
>
> So you will need to manually backport this and submit it to stable@xxxxxxxxxxxxxxx
> if you want it to be included in any of the stable kernel series.
>
> Still it is always good to have the Fixes: tag present when a commit is actually
> fixing a previous commit.
>
I wasn't aware of the linux-stable kernel so it was good to learn
about. I'll have a look at doing that process - I don't know how many
people it will really make a difference for, but if it saves a few folk
some headaches it seems worth trying.
Thank you!
Mark
