Hi,
On 2/3/21 6:36 PM, Vadim Pasternak wrote:
> Add documentation for the new attributes:
> - "lc{n}_enable" - for put/release the line card to/from enable state.
> - "lc{n}_pwr" - for power on/off the line card.
> - "lc{n}_rst_mask" - for line card reset state enforced by ASIC, when
> it sets it due to some abnormal ASIC behavior.
> - "psu3_on"; "psu4_on" - for connection/disconnection power supply unit
> to/from the power source.
> - "os_ready" - for indication that OS is taking control over systems
> programmable devices.
> - "pm_mgmt_en" - for setting power management control ownership. When
> power management control is provided by hardware, it means that
> hardware will automatically power off one or more line cards in case
> system power budget is under power required for feeding all powered
> on line cards. It could be a case, when some of power units lost
> power good state.
> - "shutdown_unlock" - for unlocking system after hardware or firmware
> thermal shutdown, which causes locking of the all interfaces to ASIC.
>
> Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxx>
> ---
> Documentation/ABI/stable/sysfs-driver-mlxreg-io | 103 ++++++++++++++++++++++++
> 1 file changed, 103 insertions(+)
>
> diff --git a/Documentation/ABI/stable/sysfs-driver-mlxreg-io b/Documentation/ABI/stable/sysfs-driver-mlxreg-io
> index fd9a8045bb0c..1d1a8ee59534 100644
> --- a/Documentation/ABI/stable/sysfs-driver-mlxreg-io
> +++ b/Documentation/ABI/stable/sysfs-driver-mlxreg-io
> @@ -223,3 +223,106 @@ Description: These files show with which CPLD part numbers and minor
> system.
>
> The files are read only.
> +
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc1_enable
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc2_enable
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc3_enable
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc4_enable
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc5_enable
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc6_enable
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc7_enable
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc8_enable
> +Date: March 2021
> +KernelVersion: 5.12
> +Contact: Vadim Pasternak <vadimp@xxxxxxxxxx>
> +Description: These files allow line cards enable state control.
> + Expected behavior:
> + When lc{n}_enable is written 1, related line card is released
> + from the reset state, when 0 - is hold in reset state.
> +
> + The files are read/write.
> +
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc1_pwr
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc2_pwr
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc3_pwr
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc4_pwr
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc5_pwr
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc6_pwr
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc7_pwr
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc8_pwr
> +Date: March 2021
> +KernelVersion: 5.12
> +Contact: Vadim Pasternak <vadimp@xxxxxxxxxx>
> +Description: These files switching line cards power on and off.
> + Expected behavior:
> + When lc{n}_pwr is written 1, related line card is powered
> + on, when written 0 - powered off.
> +
> + The files are read/write.
> +
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc1_rst_mask
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc2_rst_mask
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc3_rst_mask
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc4_rst_mask
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc5_rst_mask
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc6_rst_mask
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc7_rst_mask
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/lc8_rst_mask
> +Date: March 2021
> +KernelVersion: 5.12
> +Contact: Vadim Pasternak <vadimp@xxxxxxxxxx>
> +Description: These files clear line card reset bit enforced by ASIC, when it
> + sets it due to some abnormal ASIC behavior.
> + Expected behavior:
> + When lc{n}_rst_mask is written 1, related line card reset bit
> + is cleared, when written 0 - no effect.
> +
> + The files are read/write.
What happens when reading these ? Maybe they should be write only ?
> +
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/os_ready
> +Date: March 2021
> +KernelVersion: 5.12
> +Contact: Vadim Pasternak <vadimp@xxxxxxxxxx>
> +Description: This file, when written 1, indicates that OS is taking control
> + over systems programmable devices.
> +
> + The file is read only.
I don't understand what this file does, the description suggests (to me) that the
OS (userspace?) writes 1 to it to indicate it is taking over control from the firmware,
but then it says that this is "read only" ?
Please make the doc here a bit more clear about what this file is for.
> +
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/pm_mgmt_en
> +Date: March 2021
> +KernelVersion: 5.12
> +Contact: Vadim Pasternak <vadimp@xxxxxxxxxx>
> +Description: This file assigns power management control ownership.
> + When power management control is provided by hardware, it means
> + that hardware will automatically power off one or more line
> + cards in case system power budget is under power required for
's/under/below the/' make this sentence more clear I believe.
> + feeding all powered on line cards. It could be a case, when
> + some of power units lost power good state.
> + When pm_mgmt_en is written 1, power management control by
> + software is enabled, 0 - power management control by hardware.
> + Default is 0.
> +
> + The file is read/write.
What happens if the software is responsible and it enables all line modules and
that leads to the system going over its power-budget ?
> +
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/psu3_on
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/psu4_on
> +Date: March 2021
> +KernelVersion: 5.12
> +Contact: Vadim Pasternak <vadimp@xxxxxxxxxx>
> +Description: These files switching power supply units on and off.
> + Expected behavior:
> + When psu3_on or psu4_on is written 1, related unit will be
> + disconnected from the power source, when written 0 - connected.
> +
> + The files are write only.
> +
> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/shutdown_unlock
> +Date: March 2021
> +KernelVersion: 5.12
> +Contact: Vadim Pasternak <vadimp@xxxxxxxxxx>
> +Description: This file unlocks system after hardware or firmware thermal
> + shutdown, which causes locking of the all interfaces to ASIC.
> + When shutdown_unlock is written 1 and after that 0, it removes
> + locking.
> +
> + The file is read/write.
>
Regards,
Hans
