Re: [PATCH] platform/surface: surface3-wmi: Fix variable 'status' set but not used compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 2/4/21 12:38 PM, Hans de Goede wrote:
> Explicitly check the status rather then relying on output.pointer staying
> NULL on an error. This silences the following compiler warning:
> 
> drivers/platform/surface/surface3-wmi.c:60:14: warning: variable 'status' set but not used [-Wunused-but-set-variable]
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reviewed-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

I've added this patch to my review-hans branch, so it should show up in pdx86/for-next soon-ish.

Regards,

Hans



> ---
>  drivers/platform/surface/surface3-wmi.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/surface/surface3-wmi.c b/drivers/platform/surface/surface3-wmi.c
> index 130b6f52a600..fcd1d4fb94d5 100644
> --- a/drivers/platform/surface/surface3-wmi.c
> +++ b/drivers/platform/surface/surface3-wmi.c
> @@ -57,12 +57,16 @@ static DEFINE_MUTEX(s3_wmi_lock);
>  static int s3_wmi_query_block(const char *guid, int instance, int *ret)
>  {
>  	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
> +	union acpi_object *obj = NULL;
>  	acpi_status status;
> -	union acpi_object *obj;
>  	int error = 0;
>  
>  	mutex_lock(&s3_wmi_lock);
>  	status = wmi_query_block(guid, instance, &output);
> +	if (ACPI_FAILURE(status)) {
> +		error = -EIO;
> +		goto out_free_unlock;
> +	}
>  
>  	obj = output.pointer;
>  
> 




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux