On Mon, Jan 25, 2021 at 1:13 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > From: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > > Drop the const qualifier from the static global cur_profile > pointer declaration. > > This is a preparation patch for passing the cur_profile pointer as > parameter to the profile_get() and profile_set() callbacks so that > drivers dynamically allocating their driver-data struct, with their > platform_profile_handler struct embedded, can use this pointer to > get to their driver-data. > > Note this also requires dropping the const from the pprof > platform_profile_register() function argument. Dropping this > const is not a problem, non of the queued up consumers of > platform_profile_register() actually pass in a const pointer. > > Link: https://lore.kernel.org/linux-acpi/5e7a4d87-52ef-e487-9cc2-8e7094beaa08@xxxxxxxxxx/ > Link: https://lore.kernel.org/r/20210114073429.176462-2-jiaxun.yang@xxxxxxxxxxx > Suggested-by: Hans de Goede <hdegoede@xxxxxxxxxx> > Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > [hdegoede@xxxxxxxxxx: Also remove const from platform_profile_register()] > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > Changes in v2 (Hans de Goede): > - Not only remove the const from the global cur_profile variable declaration, > but also from the platform_profile_register() argument > - Reword commit message to match Applied as 5.12 material on top of the previous platform-profile commits, thanks! I will expose a separate branch with these commits when they get some linux-next build coverage. > --- > drivers/acpi/platform_profile.c | 4 ++-- > include/linux/platform_profile.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c > index 91be50a32cc8..f65c61db7921 100644 > --- a/drivers/acpi/platform_profile.c > +++ b/drivers/acpi/platform_profile.c > @@ -9,7 +9,7 @@ > #include <linux/platform_profile.h> > #include <linux/sysfs.h> > > -static const struct platform_profile_handler *cur_profile; > +static struct platform_profile_handler *cur_profile; > static DEFINE_MUTEX(profile_lock); > > static const char * const profile_names[] = { > @@ -132,7 +132,7 @@ void platform_profile_notify(void) > } > EXPORT_SYMBOL_GPL(platform_profile_notify); > > -int platform_profile_register(const struct platform_profile_handler *pprof) > +int platform_profile_register(struct platform_profile_handler *pprof) > { > int err; > > diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h > index 3623d7108421..c797fdb3d91a 100644 > --- a/include/linux/platform_profile.h > +++ b/include/linux/platform_profile.h > @@ -32,7 +32,7 @@ struct platform_profile_handler { > int (*profile_set)(enum platform_profile_option profile); > }; > > -int platform_profile_register(const struct platform_profile_handler *pprof); > +int platform_profile_register(struct platform_profile_handler *pprof); > int platform_profile_remove(void); > void platform_profile_notify(void); > > -- > 2.29.2 >
