On 1/17/21 4:34 AM, Barnabás Pőcze wrote:
> Hi
>
>
> 2021. január 16., szombat 20:46 keltezéssel, Andy Shevchenko írta:
>
>> On Wed, Jan 13, 2021 at 8:22 PM Barnabás Pőcze wrote:
>>>
>>> Having the device name in the log message makes it easier to determine in
>>> the context of which device the message was printed, so utilize the
>>> appropriate variants of dev_{err,warn,...} when printing log messages.
>>
>> This doesn't explain transitions like pr_err() -> dev_warn() or
>> pr_info() -> dev_warn().
>> Care to elaborate in the commit message?
>> [...]
>
> Thanks for the review, and thanks for pointing this out. I don't recall intendeding
> to promote/demote any of the log messages when I was making these changes. I will
> revisit my them and modify the commit and commit message accordingly.
>
>
> Thanks,
> Barnabás Pőcze
>
Hi,
For unknown key/wmi event, it might come from latest model on new function.
That's why it is pr_info.
For backlight_init, this should not happen. that's why it is pr_err.
I am ok if you have any though of promoting or demoting.
--
Ike Panhc
