Re: [PATCH v2 21/24] platform/x86: ideapad-laptop: add keyboard backlight control support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 17, 2021 at 12:44 AM Barnabás Pőcze <pobrn@xxxxxxxxxxxxxx> wrote:
> 2021. január 16., szombat 21:07 keltezéssel, Andy Shevchenko írta:
> > On Wed, Jan 13, 2021 at 8:25 PM Barnabás Pőcze wrote:

...

> > > +       struct {
> > > +               bool initialized;
> > > +               struct led_classdev led;
> > > +               unsigned int last_brightness;
> > > +       } kbd_bl;
> >
> > Data structure without sense.

> It makes a lot of sense to me, it groups the members which are concerned with
> keyboard backlight control. Do you have any specific issues with it? And
> what would you suggest instead?

Oops, I somehow misread it as similar to one with boolean bit fields.
Sorry, please,  disregard my comment.


-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux