https://bugzilla.kernel.org/show_bug.cgi?id=199715 --- Comment #31 from Hans de Goede (jwrdegoede@xxxxxxxxxxxxxxxxx) --- (In reply to Richard Neumann from comment #30) > $ cat /etc/modprobe.d/amd_sfh.conf > options amd_sfh_hid sensor_mask=524295 Ok, so that translates to: options amd_sfh_hid sensor_mask=0x80007 So you are enabling all 4 sensors: #define ACEL_EN BIT(0) #define GYRO_EN BIT(1) #define MAGNO_EN BIT(2) #define ALS_EN BIT(19) I assume that you have verified that all 4 work? Note that you can actually use hex-values (prefixed with 0x) when setting integer module parameters, that typically make things easier to parse in cases where the integer is a bitmask like this case. > Refactoring the driver to clean it up, make it integrate seamlessly with the > kernel APIs and providing the params to make it configurable on devices where > the manufacturers screwed up was challenging, interesting and mostly a fun > experience. Getting my work upstream, frankly, not so much. May I ask you to at least consider re-posting the series as is with the email going to the right people: [hans@x1 linux]$ scripts/get_maintainer.pl -f drivers/hid/amd-sfh-hid/amd_sfh_pcie.c Nehal Shah <nehal-bakulchandra.shah@xxxxxxx> (maintainer:AMD SENSOR FUSION HUB DRIVER) Sandeep Singh <sandeep.singh@xxxxxxx> (maintainer:AMD SENSOR FUSION HUB DRIVER) Jiri Kosina <jikos@xxxxxxxxxx> (maintainer:HID CORE LAYER) Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> (maintainer:HID CORE LAYER) linux-input@xxxxxxxxxxxxxxx (open list:AMD SENSOR FUSION HUB DRIVER) With a cover letter why you believe that your version is better / cleaner ? Note you will very probably still be asked to refactor your work so that it will consist of incremental patches which slowly moves the existing driver to your version. But this way at least the maintainers will be aware that there is room for improvement, because I'm pretty sure that they will not have seen the posting to the linux-iio list. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
