On Wed, Jan 13, 2021 at 8:24 PM Barnabás Pőcze <pobrn@xxxxxxxxxxxxxx> wrote:
>
> Certain models have a so-called "always on USB charging" feature, which
> enables USB charging even when the computer is turned off or suspended,
> and which may be controlled/queried using the SALS/HALS ACPI methods.
> Expose this functionality via a new device attribute (usb_charging).
> Tested on: Lenovo YOGA 520-14IKB 80X8
...
> enum {
> - HALS_KBD_BL_SUPPORT_BIT = 4,
> - HALS_KBD_BL_STATE_BIT = 5,
> - HALS_FNLOCK_SUPPORT_BIT = 9,
> - HALS_FNLOCK_STATE_BIT = 10,
> - HALS_HOTKEYS_PRIMARY_BIT = 11,
> + HALS_KBD_BL_SUPPORT_BIT = 4,
> + HALS_KBD_BL_STATE_BIT = 5,
> + HALS_USB_CHARGING_SUPPORT_BIT = 6,
> + HALS_USB_CHARGING_STATE_BIT = 7,
> + HALS_FNLOCK_SUPPORT_BIT = 9,
> + HALS_FNLOCK_STATE_BIT = 10,
> + HALS_HOTKEYS_PRIMARY_BIT = 11,
> };
>
> enum {
> - SALS_KBD_BL_ON = 0x8,
> - SALS_KBD_BL_OFF = 0x9,
> - SALS_FNLOCK_ON = 0xe,
> - SALS_FNLOCK_OFF = 0xf,
> + SALS_KBD_BL_ON = 0x8,
> + SALS_KBD_BL_OFF = 0x9,
> + SALS_USB_CHARGING_ON = 0xa,
> + SALS_USB_CHARGING_OFF = 0xb,
> + SALS_FNLOCK_ON = 0xe,
> + SALS_FNLOCK_OFF = 0xf,
> };
Twice in the same series you reindented these. Please, indent them
correctly in the first place.
--
With Best Regards,
Andy Shevchenko
