Hi, I know there already is a v3 out and I will try to get around to reviewing that soon, still 1 remark about the discussion surrounding v2: On 1/11/21 2:42 PM, Perry Yuan wrote: <snip> >>> *The flow is like this: >>> 1) User presses key. HW does stuff with this key (timeout is started) >>> 2) Event is emitted from FW >>> 3) Event received by dell-privacy >>> 4) KEY_MICMUTE emitted from dell-privacy >>> 5) Userland picks up key and modifies kcontrol for SW mute >>> 6) Codec kernel driver catches and calls ledtrig_audio_set, like this: >>> ledtrig_audio_set(LED_AUDIO_MICMUTE, >>> rt715->micmute_led ? LED_ON :LED_OFF); >>> 7) If "LED" is set to on dell-privacy notifies ec, >>> and timeout is cancelled,HW mic mute activated. >>> >> Please proofread the commit message again, and pay attention to capitalization >> and spacing. > I want to reformat it and move the commit info to cover letter. Please also put a copy of this as a comment in either the wmi or the acpi driver (with a comment pointing to the comment in the other) this is important info to have for someone reading the code and trying to understand how this all fits together. Regards, Hans
