Hi, On 1/6/21 9:49 PM, Barnabás Pőcze wrote: > 2021. január 6., szerda 19:23 keltezéssel, Hans de Goede írta: > >> [...] >> Thank you for this series, it is good to see all the >> cleanups, as well as to see the new functionality. >> >> Patches 1-20 and 22-24 look good to me and you may add my: >> >> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> >> To them for v2 of this patch-set. >> > > Thanks for the review. > > >> I have some remarks about patch 21 I will reply to that one >> separately. >> >> One minor remark about patch 3/24, normally we put all >> the #include <linux/foo.h> includes first (sorted >> alphabetically as you already do in the patch) and then >> follow up by other / subsys specific include such as >> acpi/video.h. Again sorted alphabetically for the file-names >> after the subsys dir. I don't think there really is any >> preferred order for which subsys headers to include first, >> but typically the generic linux/foo.h headers are included >> first. >> > > I will change the order as requested. > > >> Regards, >> >> Hans >> >> p.s. >> >> About merging this series vs other outstanding ideapad-laptop >> changes. The other outstanding changes are quite small, so easy >> to rebase. As such I would actually prefer to merge this series >> first. So if you can send out a v2 soon-ish, then that would be >> great. > > That would make it harder to backport, no? As far as I remember, the patch[1] was > sent to stable@xxxxxxxxxx as well. > > [1]: https://lore.kernel.org/platform-driver-x86/20210103033651.47580-1-jiaxun.yang@xxxxxxxxxxx/#t That is true. So lets get that patch merged first, and then you can base your v2 on top of that. Jiaxun, can you send out a v4 of your "[PATCH fixes v3] platform/x86: ideapad-laptop: Disable touchpad_switch for ELAN0634" patch addressing my review remark on v3 ? Regards, Hans
