On 04/01/2021 10:32, Hans de Goede wrote: > Hi, > > On 1/4/21 4:17 PM, Andy Shevchenko wrote: >> On Wed, Dec 30, 2020 at 4:54 AM Mark Pearson >> <markpearson@xxxxxxxxxx> wrote: >>> >>> The previous commit adding functionality for the palm sensor had >>> a mistake which meant the error conditions on initialisation was >>> not checked correctly. On some older platforms this meant that if >>> the sensor wasn't available an error would be returned and the >>> driver would fail to load. >> >>> This commit corrects the error condition. Many thanks to Mario >>> Oenning for reporting and determining the issue >> >> Hint to the future (maybe Hans will fix this while it's in his >> review queue): we have a Reported-by tag. Of course if a person >> would like to avoid it, then it's fine. > > I did notice this too, but I did not fix it. For future patches the > right thing to do is to ask the reporter if he is ok with a > Reported-by tag being added (which will expose their email to the > world) and then proceed depending on their answer, at least that is > what I usually do. Although sometimes I do just add the Reported-by > tag, esp. if the email has been send to a (couple of) lists, so the > email already has been exposed to a large audience. > Ack - thanks all. I wasn't aware of the reported-by etiquette :) Probably a good one to know about....I'm sure this won't be the last issue reported against a Lenovo system! Mark
