2021. január 4., hétfő 15:03 keltezéssel, Hans de Goede írta:
> Hi Barnabás,
>
> On 1/4/21 1:03 PM, Barnabás Pőcze wrote:
>
> > 2020. december 16., szerda 2:39 keltezéssel, Barnabás Pőcze írta:
> >
> > > This series contains patches that aim to bring more consistency
> > > to the code; add keyboard backlight control support; add
> > > "always on USB charging" control support.
> > > Furthermore, commit 7f363145992cebf4ea760447f1cfdf6f81459683 is reverted
> > > since it made it impossible to disable/enable the touchpad via the
> > > ideapad-laptop module and on some devices the method implemented in the
> > > module works correctly to disable/enable the touchpad.
> > > Barnabás Pőcze (24):
> > > platform/x86: ideapad-laptop: remove unnecessary dev_set_drvdata()
> > > call
> > > platform/x86: ideapad-laptop: use appropriately typed variable to
> > > store the return value of ACPI methods
> > > platform/x86: ideapad-laptop: sort includes lexicographically
> > > platform/x86: ideapad-laptop: use sysfs_emit()
> > > platform/x86: ideapad-laptop: use for_each_set_bit() helper to
> > > simplify event processing
> > > platform/x86: ideapad-laptop: use msecs_to_jiffies() helper instead of
> > > hand-crafted formula
> > > platform/x86: ideapad-laptop: use dev_{err,warn} or appropriate
> > > variant to display log messages
> > > platform/x86: ideapad-laptop: convert ACPI helpers to return -EIO in
> > > case of failure
> > > platform/x86: ideapad-laptop: always propagate error codes from device
> > > attributes' show() callback
> > > platform/x86: ideapad-laptop: misc. device attribute changes
> > > platform/x86: ideapad-laptop: group and separate (un)related constants
> > > into enums
> > > platform/x86: ideapad-laptop: rework and create new ACPI helpers
> > > platform/x86: ideapad-laptop: rework is_visible() logic
> > > platform/x86: ideapad-laptop: check for Fn-lock support in HALS
> > > platform/x86: ideapad-laptop: check for touchpad support in _CFG
> > > platform/x86: ideapad-laptop: change 'status' debugfs file format
> > > platform/x86: ideapad-laptop: change 'cfg' debugfs file format
> > > Revert "platform/x86: ideapad-laptop: Switch touchpad attribute to be
> > > RO"
> > > platform/x86: ideapad-laptop: fix checkpatch warnings, more consistent
> > > style
> > > platform/x86: ideapad-laptop: send notification about touchpad state
> > > change to sysfs
> > > platform/x86: ideapad-laptop: add keyboard backlight control support
> > > platform/x86: ideapad-laptop: add "always on USB charging" control
> > > support
> > > Documentation/ABI: sysfs-platform-ideapad-laptop: update device
> > > attribute paths
> > > Documentation/ABI: sysfs-platform-ideapad-laptop: conservation_mode
> > > and usb_charging
> > > .../ABI/testing/sysfs-platform-ideapad-laptop | 26 +-
> > > drivers/platform/x86/ideapad-laptop.c | 1047 +++++++++++------
> > > 2 files changed, 692 insertions(+), 381 deletions(-)
> > >
> > > 2.29.2
> >
> > A patch in the series a serious flaw which I have just noticed;
> > I will send a new version when the situation about a conflicting
> > patch1 becomes clear.
>
> Thank you for the headsup, I will try to make some time to review v1
> of this series, so that you can take any review-remarks which I might
> have into account when posting v2 (or add my reviewed-by for patches
> for which I have no remark).
>
> May I ask which patch is flawed and what the flaw is ? Then I can skip
> that while reviewing. I hope to get around to reviewing v1 (this version)
> of this series this Wednesday (but no promises).
>
Hi
In "platform/x86: ideapad-laptop: check for touchpad support in _CFG", the bit
is off by one. It should be 30, not 31.
Regards,
Barnabás Pőcze
