On Mon, 21 Dec 2020 19:39:55 +0100 Maximilian Luz <luzmaximilian@xxxxxxxxx> wrote: > This commit adds error injection hooks to the Surface Serial Hub > communication protocol implementation, to: > > - simulate simple serial transmission errors, > > - drop packets, requests, and responses, simulating communication > failures and potentially trigger retransmission timeouts, as well as > > - inject invalid data into submitted and received packets. > > Together with the trace points introduced in the previous commit, these > facilities are intended to aid in testing, validation, and debugging of > the Surface Aggregator communication layer. > > Signed-off-by: Maximilian Luz <luzmaximilian@xxxxxxxxx> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > > Changes in v1 (from RFC): > - remove unnecessary default in Kconfig entry > > Changes in v2: > - use dedicated trace event class for data error injection > - spell check comments and strings, fix typos > - unify comment style > - run checkpatch --strict, fix warnings and style issues > >From a tracing point of view: Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> -- Steve > --- > drivers/platform/surface/aggregator/Kconfig | 14 + > .../surface/aggregator/ssh_packet_layer.c | 296 +++++++++++++++++- > .../surface/aggregator/ssh_request_layer.c | 35 +++ > drivers/platform/surface/aggregator/trace.h | 31 ++ > 4 files changed, 375 insertions(+), 1 deletion(-) >
