On Sat, Dec 12, 2020 at 7:05 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > On 12/12/20 5:24 AM, Andy Shevchenko wrote: > > On Fri, Dec 11, 2020 at 9:20 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: ... > >> +#ifdef CONFIG_PM_SLEEP > >> static int surface_gpe_suspend(struct device *dev) > > > > Perhaps __maybe_unused ? > > Yes, I am aware of that option. > I don't know why it would be preferred though. Here [1] is the rationale behind annotation vs. ifdeffery. [1]: https://lore.kernel.org/patchwork/patch/732981/ -- With Best Regards, Andy Shevchenko