Hi, On 12/8/20 1:28 PM, Zou Wei wrote: > Fix the following sparse warnings: > > drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24: warning: symbol 'mmio_range_devid_0' was not declared. Should it be static? > drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:28:24: warning: symbol 'mmio_range_devid_1' was not declared. Should it be static? > > Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c > index 2906cfe..ff49025 100644 > --- a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c > +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c > @@ -20,12 +20,12 @@ struct isst_mmio_range { > int end; > }; > > -struct isst_mmio_range mmio_range_devid_0[] = { > +static struct isst_mmio_range mmio_range_devid_0[] = { > {0x04, 0x14}, > {0x20, 0xD0}, > }; > > -struct isst_mmio_range mmio_range_devid_1[] = { > +static struct isst_mmio_range mmio_range_devid_1[] = { > {0x04, 0x14}, > {0x20, 0x11C}, > }; >