On 03/12/2020 22:22, Peter Kästle wrote: > 3. Dezember 2020 08:17, "Daniel Lezcano" <daniel.lezcano@xxxxxxxxxx> schrieb: > >> Currently the code checks the interval value when the temperature is >> read which is bad for two reasons: >> >> - checking and setting the interval in the get_temp callback is >> inaccurate and awful, that can be done when changing the value. >> >> - Changing the thermal zone structure internals is an abuse of the >> exported structure, moreover no lock is taken here. >> >> The goal of this patch is to solve the first item by using the 'set' >> function called when changing the interval. The check is done there >> and removed from the get_temp function. If the thermal zone was not >> initialized yet, the interval is not updated in this case as that will >> happen in the init function when registering the thermal zone device. > > Thanks for your effort. This improves the code, good finding. > > >> I don't have any hardware to test the changes. > > Tests successfully executed on my good old AOA110. > > >> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> > > Acked-by: Peter Kaestle <peter@xxxxxxxx> Thanks for testing the changes. Shall pick the patches through the thermal tree ? -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
