Hi, Please help to pick it up after 5.11-rc1, thanks a lot. -----邮件原件----- 发件人: Hans de Goede [mailto:hdegoede@xxxxxxxxxx] 发送时间: 2020年11月30日 21:31 收件人: Zouwei (Samuel) <zou_wei@xxxxxxxxxx>; justin.ernst@xxxxxxx; mgross@xxxxxxxxxxxxxxx 抄送: platform-driver-x86@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx 主题: Re: [PATCH -next] x86/platform/uv: Mark some symbols with static keyword Hi, +Cc x86 folks On 11/30/20 12:11 PM, Zou Wei wrote: > Fix the following sparse warnings: > > drivers/platform/x86/uv_sysfs.c:22:13: warning: symbol 'uv_pcibus_kset' was not declared. Should it be static? > drivers/platform/x86/uv_sysfs.c:23:13: warning: symbol 'uv_hubs_kset' was not declared. Should it be static? > > Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx> Since this is a fix to a series merged through the x86/tip tree, this should be merged to the x86/tip tree too (or I can pick it up after 5.11-rc1). Here is my ack for merging this through the x86/tip tree: Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans > --- > drivers/platform/x86/uv_sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/uv_sysfs.c > b/drivers/platform/x86/uv_sysfs.c index 54c3425..c780a4b 100644 > --- a/drivers/platform/x86/uv_sysfs.c > +++ b/drivers/platform/x86/uv_sysfs.c > @@ -19,8 +19,8 @@ > #define INVALID_CNODE -1 > > struct kobject *sgi_uv_kobj; > -struct kset *uv_pcibus_kset; > -struct kset *uv_hubs_kset; > +static struct kset *uv_pcibus_kset; > +static struct kset *uv_hubs_kset; > static struct uv_bios_hub_info *hub_buf; static struct > uv_bios_port_info **port_buf; static struct uv_hub **uv_hubs; >
