Hi,
On 11/27/20 2:24 AM, Luo Meng wrote:
> Fix to return a negative error code from the error handling case
> instead of 0 in function dell_smbios_init(), as done elsewhere in this
> function.
>
> Fixes: 25d47027e100 ("platform/x86: dell-smbios: Link all dell-smbios-* modules together")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Luo Meng <luomeng12@xxxxxxxxxx>
A colleague of you already submitted the exact same fix:
https://patchwork.kernel.org/project/platform-driver-x86/patch/20201125065032.154125-1-miaoqinglang@xxxxxxxxxx/
I'm waiting on a review from Dell on that one before merging it.
Regards,
Hans
> ---
> drivers/platform/x86/dell-smbios-base.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
> index 2e2cd565926a..3a1dbf199441 100644
> --- a/drivers/platform/x86/dell-smbios-base.c
> +++ b/drivers/platform/x86/dell-smbios-base.c
> @@ -594,6 +594,7 @@ static int __init dell_smbios_init(void)
> if (wmi && smm) {
> pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n",
> wmi, smm);
> + ret = -ENODEV;
> goto fail_create_group;
> }
>
>
