Hi, Quick self intro: I have take over drivers/platform/x86 maintainership from Andy; and I'm working my way through the backlog of old patches in patchwork: https://patchwork.kernel.org/project/platform-driver-x86/list/ On 8/4/20 2:14 AM, Timo Witte wrote: > Got a dmesg message on my AMD Renoir based Acer laptop: > "acer_wmi: Unknown key number - 0x84" when toggling keyboard > background light > > Signed-off-by: Timo Witte <timo.witte@xxxxxxxxx> > Reviewed-by: "Lee, Chun-Yi" <jlee@xxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans I've made one small change I've replaced the (ignored) KEY_LIGHTS_TOGGLE key-code with KEY_KBDILLUMTOGGLE as that is the correct code to use for toggling the kbd backlight on/off. As the comment in input-event-codes.h says KEY_LIGHTS_TOGGLE is for "/* Reading light on or off */". Note this will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/acer-wmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c > index 60c18f21588d..87797f785d6a 100644 > --- a/drivers/platform/x86/acer-wmi.c > +++ b/drivers/platform/x86/acer-wmi.c > @@ -111,6 +111,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = { > {KE_KEY, 0x64, {KEY_SWITCHVIDEOMODE} }, /* Display Switch */ > {KE_IGNORE, 0x81, {KEY_SLEEP} }, > {KE_KEY, 0x82, {KEY_TOUCHPAD_TOGGLE} }, /* Touch Pad Toggle */ > + {KE_IGNORE, 0x84, {KEY_LIGHTS_TOGGLE} }, /* Automatic Keyboard background light toggle */ > {KE_KEY, KEY_TOUCHPAD_ON, {KEY_TOUCHPAD_ON} }, > {KE_KEY, KEY_TOUCHPAD_OFF, {KEY_TOUCHPAD_OFF} }, > {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} }, >
