Hi Andy, On 11/4/2020 4:19 AM, Andy Shevchenko wrote: > [CAUTION: External Email] > > On Thu, Oct 29, 2020 at 10:57 AM Shyam Sundar S K > <Shyam-sundar.S-k@xxxxxxx> wrote: >> >> AMD Power Management Controller driver aka. amd-pmc driver is the > > aka. -> a.k.a. or AKA > >> controller which is meant for final S2Idle transaction that goes to the > > for the final > >> PMFW running on the AMD SMU (System Management Unit) responsible for >> tuning of the VDD. >> >> Once all the monitored list or the idle constraints are met, this driver >> would go and set the OS_HINT (meaning all the devices have reached to >> their lowest state possible) via the SMU mailboxes. >> >> This driver would also provide some debug capabilities via debugfs. > > ... > >> +F: drivers/platform/x86/amd-pmc.c >> +F: drivers/platform/x86/amd-pmc.h > > Can be one entry. > I have addressed the comments. can you please review it again? - Shyam