Hi, On 11/3/20 1:28 PM, Shyam Sundar S K wrote: > Hi Hans, > > On 10/29/2020 12:26 AM, Shyam Sundar S K wrote: >> AMD Power Management Controller driver aka. amd-pmc driver is the >> controller which is meant for final S2Idle transaction that goes to the >> PMFW running on the AMD SMU (System Management Unit) responsible for >> tuning of the VDD. >> >> Once all the monitored list or the idle constraints are met, this driver >> would go and set the OS_HINT (meaning all the devices have reached to >> their lowest state possible) via the SMU mailboxes. >> >> This driver would also provide some debug capabilities via debugfs. >> >> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> >> --- >> Changes since v1:(https://www.spinics.net/lists/platform-driver-x86/msg23269.html) >> - Remove duplicate code and make a common routine for polling SMU >> - Reorg Maintainers info >> - add missing iounmap() during erroneous case. >> > > any feedback on this patch, please? I have reviewing this on my to do list, some patience please. Regards, Hans