Hi, On 11/3/20 11:39 AM, Andy Shevchenko wrote: > On Tue, Nov 3, 2020 at 12:22 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> On 11/3/20 1:04 AM, Linus Walleij wrote: >>> This makes the machine look up the LED from a GPIO machine >>> descriptor table. The Geode LEDs should be on the CS5535 >>> companion chip. >>> >>> Cc: linux-gpio@xxxxxxxxxxxxxxx >>> Cc: Andres Salomon <dilinger@xxxxxxxxxx> >>> Cc: linux-geode@xxxxxxxxxxxxxxxxxxx >>> Cc: Darren Hart <dvhart@xxxxxxxxxxxxx> >>> Cc: platform-driver-x86@xxxxxxxxxxxxxxx >>> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> >>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> >> >> Linus, in case you did not know yet, I have take over >> drivers/platform/x86 maintainership from Andy. >> >> Andy, the MAINTAINERS entry for arch/x86/platform says: > > Yes, it's a bit orthogonal to PDx86, but it makes sense to have the > below list of reviewers to be in sync with PDx86 maintainers. I'm > happy to give my place in the below to you. I'm not familiar with most of the code there, so how about adding me while keeping you there too ? And maybe drop Darren I guess ? Darren if you are reading along, please let us know what you want. >> X86 PLATFORM DRIVERS - ARCH >> R: Darren Hart <dvhart@xxxxxxxxxxxxx> >> R: Andy Shevchenko <andy@xxxxxxxxxxxxx> >> L: platform-driver-x86@xxxxxxxxxxxxxxx >> L: x86@xxxxxxxxxx >> S: Maintained >> T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/core >> F: arch/x86/platform >> >> Andy, so I guess that with your Reviewed-by added, these are expected to >> get picked up by the tip tree people ? > > That's correct. > >> Linus, it seems that you did not "Cc: x86@xxxxxxxxxx" which is >> listed in MAINTAINERS for these, and is probably necessary to >> get these merged through the tip tree. >> >> Note I'm happy to pick these up through: >> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/ >> >> I actually had them in my local review-hans branch before noticing that >> that they went to arch/x86/platform. But I've dropped them now as I'm >> not sure if merging them through the pdx86 tree is the right thing to do, >> the MAINTAINERS file at least suggests things should be done differently. > > arch/x86 should go via TIP tree, except cases confirmed by TIP maintainers. Ok, then I think a v4 with the TIP maintainers actually in the addressing list is necessary. >> Linus, if a v4 with "Cc: x86@xxxxxxxxxx" is necessary you may add my: >> >> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> >> To the entire series. And this still applies. Regards, Hans
