On 10/28/20 4:54 PM, Shyam Sundar S K wrote: > Hi Hans, > > On 10/28/2020 5:48 PM, Hans de Goede wrote: >> [CAUTION: External Email] >> >> Hi, >> >> On 10/23/20 10:04 AM, Shyam Sundar S K wrote: >>> AMD Power Management Controller driver aka. amd-pmc driver is the >>> controller which is meant for final S2Idle transaction that goes to the >>> PMFW running on the AMD SMU (System Management Unit) responsible for >>> tuning of the VDD. >>> >>> Once all the monitored list or the idle constraints are met, this driver >>> would go and set the OS_HINT (meaning all the devices have reached to >>> their lowest state possible) via the SMU mailboxes. >>> >>> This driver would also provide some debug capabilities via debugfs. >>> >>> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> >> Thank you for your patch, I have various review remarks, see my >> comments inline. > > Adding Alex.. > > Thank you Hans for the feedback. I have sent a v2, can you please review it. It looks like something went wrong with the sending of the v2, I do not see it in my inbox, nor is it in patchwork: https://patchwork.kernel.org/project/platform-driver-x86/list/ Regards, Hans
