On Thu, Oct 8, 2020 at 5:35 PM Maximilian Luz <luzmaximilian@xxxxxxxxx> wrote: > > As has come up in the discussion around > > [RFC PATCH] Add support for Microsoft Surface System Aggregator Module > > it may make sense to add a Microsoft Surface specific platform > subdirectory. Andy has suggested drivers/platform/surface for that. > This series follows said suggestion and creates that subdirectory, as > well as moves Microsoft Surface related drivers over to it and updates > their MAINTAINERS entries (if available) accordingly. > > This series does not modify any existing driver code, symbols, or help > text. > > More details regarding maintainership can be found in > > [PATCH v3 1/5] platform: Add Surface platform directory For patches 3-5 Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> 1 and 2 have minor comments You may add my Rb tag after addressing if you agree on them. > Link to discussion: > https://lore.kernel.org/lkml/CAHp75Vfp86h38Rd-VEgER7ASADdmz5ymAkuHvD0Q6WPDqZBqHw@xxxxxxxxxxxxxx/ > > Cc: Hans de Goede <hdegoede@xxxxxxxxxx> > Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > Changes in v2: > - Rebase onto linux-platform-drivers-x86/for-next to incorporate > changes in Maintainer file. > > Changes in v3: > - Add separate MAINTAINERS entry for platform/surface > - Add Maximilian Luz as reviewer for platform/surface > > For more details regarding changes, refer to the individual patches. > > Maximilian Luz (5): > platform: Add Surface platform directory > platform/surface: Move Surface 3 WMI driver to platform/surface > platform/surface: Move Surface 3 Button driver to platform/surface > platform/surface: Move Surface 3 Power OpRegion driver to > platform/surface > platform/surface: Move Surface Pro 3 Button driver to platform/surface > > MAINTAINERS | 11 ++++- > drivers/platform/Kconfig | 2 + > drivers/platform/Makefile | 1 + > drivers/platform/surface/Kconfig | 49 +++++++++++++++++++ > drivers/platform/surface/Makefile | 10 ++++ > .../platform/{x86 => surface}/surface3-wmi.c | 0 > .../{x86 => surface}/surface3_button.c | 0 > .../{x86 => surface}/surface3_power.c | 0 > .../{x86 => surface}/surfacepro3_button.c | 0 > drivers/platform/x86/Kconfig | 31 ------------ > drivers/platform/x86/Makefile | 6 --- > 11 files changed, 72 insertions(+), 38 deletions(-) > create mode 100644 drivers/platform/surface/Kconfig > create mode 100644 drivers/platform/surface/Makefile > rename drivers/platform/{x86 => surface}/surface3-wmi.c (100%) > rename drivers/platform/{x86 => surface}/surface3_button.c (100%) > rename drivers/platform/{x86 => surface}/surface3_power.c (100%) > rename drivers/platform/{x86 => surface}/surfacepro3_button.c (100%) > > -- > 2.28.0 > -- With Best Regards, Andy Shevchenko