On Thu, Oct 8, 2020 at 5:35 PM Maximilian Luz <luzmaximilian@xxxxxxxxx> wrote: > > It may make sense to split the Microsoft Surface hardware platform > drivers out to a separate subdirectory, since some of it may be shared > between ARM and x86 in the future (regarding devices like the Surface > Pro X). > > Further, newer Surface devices will require additional platform drivers > for fundamental support (mostly regarding their embedded controller), > which may also warrant this split from a size perspective. > > This commit introduces a new platform/surface subdirectory for the > Surface device family, with subsequent commits moving existing Surface > drivers over from platform/x86. > > A new MAINTAINERS entry is added for this directory. Patches to files in > this directory will be taken up by the platform-drivers-x86 team (i.e. > Hans de Goede and Mark Gross) after they have been reviewed by > Maximilian Luz. Thanks for the patch, my minor comments below. ... > +MICROSOFT SURFACE PLATFORM DRIVERS (1) > +M: Hans de Goede <hdegoede@xxxxxxxxxx> > +M: Mark Gross <mgross@xxxxxxxxxxxxxxx> > +M: Maximilian Luz <luzmaximilian@xxxxxxxxx> > +L: platform-driver-x86@xxxxxxxxxxxxxxx > +S: Maintained > +T: git git://git.infradead.org/linux-platform-drivers-x86.git It's now on kernel.org. git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git > +F: drivers/platform/surface/ > @@ -9,3 +9,4 @@ obj-$(CONFIG_MIPS) += mips/ > obj-$(CONFIG_OLPC_EC) += olpc/ > obj-$(CONFIG_GOLDFISH) += goldfish/ > obj-$(CONFIG_CHROME_PLATFORMS) += chrome/ > +obj-$(CONFIG_SURFACE_PLATFORM) += surface/ (2) > +menuconfig SURFACE_PLATFORM (3a) > +if SURFACE_PLATFORM (3b) > +endif # SURFACE_PLATFORM (3c) I think in (1), (2) and (3) it makes sense to mimic Chrome, i.e. use plural: PLATFORMS. -- With Best Regards, Andy Shevchenko