On Wed, 07 Oct 2020, David E. Box wrote: > On Wed, 2020-10-07 at 07:57 +0100, Lee Jones wrote: > > On Fri, 02 Oct 2020, David E. Box wrote: > > > > > Intel Platform Monitoring Technology (PMT) is an architecture for > > > enumerating and accessing hardware monitoring facilities. PMT > > > supports > > > multiple types of monitoring capabilities. This driver creates > > > platform > > > devices for each type so that they may be managed by capability > > > specific > > > drivers (to be introduced). Capabilities are discovered using PCIe > > > DVSEC > > > ids. Support is included for the 3 current capability types, > > > Telemetry, > > > Watcher, and Crashlog. The features are available on new Intel > > > platforms > > > starting from Tiger Lake for which support is added. This patch > > > adds > > > support for Tiger Lake (TGL), Alder Lake (ADL), and Out-of-Band > > > Management > > > Services Module (OOBMSM). > > > > > > Also add a quirk mechanism for several early hardware differences > > > and bugs. > > > For Tiger Lake and Alder Lake, do not support Watcher and Crashlog > > > capabilities since they will not be compatible with future product. > > > Also, > > > fix use a quirk to fix the discovery table offset. > > > > > > Co-developed-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx > > > > > > > Signed-off-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx> > > > Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx> > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > > --- > > > MAINTAINERS | 5 + > > > drivers/mfd/Kconfig | 10 ++ > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/intel_pmt.c | 226 > > > ++++++++++++++++++++++++++++++++++++++++ > > > 4 files changed, 242 insertions(+) > > > create mode 100644 drivers/mfd/intel_pmt.c > > > > I Acked this back in August. > > > > Any reason why you didn't carry it forward? > > So that you could review changes made after the Ack. > Please let me know if this is not preferred. Thanks. No, that is the correct way to do things (see below). > You did and you requested fixups which were made. Keeping the status of each and every patch-set currently in my inbox would be a very difficult task. This is why I recommend patch-level changelogs (just below the '---' marker). -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
