Re: [External] Re: [PATCH v2] platform/x86: thinkpad_acpi: performance mode interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On 9/17/2020 7:39 AM, Hans de Goede wrote:
Hi,

On 8/21/20 7:53 PM, Mark Pearson wrote:
Lenovo Thinkpad platforms with DYTC version 5 and newer have enhanced
firmware to provide different performance/thermal modes.

<Snip>


So we recently had another driver show up with almost the same interface / thing:

https://patchwork.kernel.org/patch/11774509/

So I believe that we really should come up with a standardize sysfs interface
for this under /sys/class/<some-name>

Please see the "RFC: offering a standardized (/sys/class) userspace API for selecting
system/laptop performance-profiles" mail thread which I just started.

Note I've not looked at the rest of this patch at all yet. But this patch should not be merged until the userspace API question is settled so nack to this patch
for now (sorry).

Mark, once we have an agreement on what the userspace API for this should
look like I can implement a small helper-library / class-core for registering the class device for this, modify this patch to use that and test it on a X1C8.

Or if you prefer you can do this yourself. Please let me know how you want to
proceed with this.
I'll join in that thread and depending on what is involved and the level of kernel expertise involved will contribute as much as I can. For sure will modify, integrate and test this implementation once that is available.

If there is a way I can 'tweak' this patch to expose the current performance mode to users in a way that is acceptable until the generic solution is available let me know and I'll do that. I'm just guessing that a generic solution needing input from multiple vendors could take a little while to develop - having a way to check what mode your system is in is really useful given you can change the mode using hotkeys.

Mark




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux