On Mon, Jul 27, 2020 at 12:02 PM Shravan Kumar Ramani <sramani@xxxxxxxxxxxx> wrote: > > The performance modules in BlueField are present in several hardware > blocks and each block provides access to these stats either through > counters that can be programmed to monitor supported events or > through memory-mapped registers that hold the relevant information. > The hardware blocks that include a performance module are: > * Tile (block containing 2 cores and a shared L2 cache) > * TRIO (PCIe root complex) > * MSS (Memory Sub-system containing the Memory Controller and L3 cache) > * GIC (Interrupt controller) > * SMMU (System Memory Management Unit) > The mlx_pmc driver provides access to all of these performance modules > through a hwmon sysfs interface. Just brief comments: - consider to revisit header block to see what is really necessary and what can be dropped - add comma to the arrays where last line is not a termination - look at match_string() / sysfs_match_string() API, I think they can be utilised here - UUID manipulations (esp. with that GUID_INIT() against non-constant) seems too much, consider refactoring and cleaning up these pieces - use kstroto*() API instead of sscanf. It has a range check -- With Best Regards, Andy Shevchenko
