On 7/15/2020 7:55 PM, Randy Dunlap wrote:
On 7/13/20 11:23 PM, David E. Box wrote:
Add PCIe DVSEC extended capability ID and defines for the header offsets.
Defined in PCIe r5.0, sec 7.9.6.
Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
---
include/uapi/linux/pci_regs.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
index f9701410d3b5..09daa9f07b6b 100644
--- a/include/uapi/linux/pci_regs.h
+++ b/include/uapi/linux/pci_regs.h
@@ -720,6 +720,7 @@
+#define PCI_EXT_CAP_ID_DVSEC 0x23 /* Designated Vendor-Specific */
@@ -1062,6 +1063,10 @@
+/* Designated Vendor-Specific (DVSEC, PCI_EXT_CAP_ID_DVSEC) */
+#define PCI_DVSEC_HEADER1 0x4 /* Vendor-Specific Header1 */
+#define PCI_DVSEC_HEADER2 0x8 /* Vendor-Specific Header2 */
Just a little comment: It would make more sense to me to
s/DVSEC/DVSPEC/g.
But then I don't have the PCIe documentation.
Arguably some of the confusion might be from the patch title. DVSEC is
acronym for Designated Vendor-Specific Extended Capability if I recall
correctly. It would probably be best to call that out since the extended
implies it lives in the config space accessible via the memory mapped
config.
