On Sat, Jul 11, 2020 at 12:43 PM Armas Spann <zappel@xxxxxxxxxxxxx> wrote:
>
> This is accomplished by two new quirk_entry structs (one for each series),
> as well as all current available G401I/G502I DMI_PRODUCT_NAMES to match
> the corresponding devices.
>
I'm going to apply this, but for the future...
> Signed-off-by: Armas Spann <zappel@xxxxxxxxxxxxx>
> ---
> asus-nb-wmi: add support for ASUS ROG Zephyrus G14 (GA401I) and G15 (GA502I)
...this actually should be a subject of the patch. But here you put
something like:
>
> drivers/platform/x86/asus-nb-wmi.c | 82 ++++++++++++++++++++++++++++++
> 1 file changed, 82 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 8c4d00482ef0..2794b840fc29 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -110,6 +110,16 @@ static struct quirk_entry quirk_asus_forceals = {
> .wmi_force_als_set = true,
> };
>
> +static struct quirk_entry quirk_asus_ga401i = {
> + .wmi_backlight_power = true,
> + .wmi_backlight_set_devstate = true,
> +};
> +
> +static struct quirk_entry quirk_asus_ga502i = {
> + .wmi_backlight_power = true,
> + .wmi_backlight_set_devstate = true,
> +};
> +
> static int dmi_matched(const struct dmi_system_id *dmi)
> {
> pr_info("Identified laptop model '%s'\n", dmi->ident);
> @@ -411,6 +421,78 @@ static const struct dmi_system_id asus_quirks[] = {
> },
> .driver_data = &quirk_asus_forceals,
> },
> + {
> + .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. GA401IH",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IH"),
> + },
> + .driver_data = &quirk_asus_ga401i,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. GA401II",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "GA401II"),
> + },
> + .driver_data = &quirk_asus_ga401i,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. GA401IU",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IU"),
> + },
> + .driver_data = &quirk_asus_ga401i,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. GA401IV",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IV"),
> + },
> + .driver_data = &quirk_asus_ga401i,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. GA401IVC",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "GA401IVC"),
> + },
> + .driver_data = &quirk_asus_ga401i,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. GA502II",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "GA502II"),
> + },
> + .driver_data = &quirk_asus_ga502i,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. GA502IU",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "GA502IU"),
> + },
> + .driver_data = &quirk_asus_ga502i,
> + },
> + {
> + .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. GA502IV",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "GA502IV"),
> + },
> + .driver_data = &quirk_asus_ga502i,
> + },
> {},
> };
>
> --
> 2.27.0
>
--
With Best Regards,
Andy Shevchenko
