On Fri, May 29, 2020 at 12:28 PM Nickolai Kozachenko
<daemongloom@xxxxxxxxx> wrote:
>
> HEBC method reports capabilities of 5 button array but HP Spectre X2
> (2015) does not have this control method (the same was for Wacom
> MobileStudio Pro). Previous DMI quirk by Alex Hung was expanded to also
> enable 5 button array for this system.
Thanks for your contribution!
Looks like your patch is mangled, please use `git format-patch ... &&
git send-email ...` to send patches.
Also, with help of get_maintainers.pl script add subsystem maintainers
and not only driver's.
P.S. When send a new version supply its number via `git format-patch
-v<n> ...` where `<n>` is 2 in this case.
Also, after cutter line ('---') add a small changelog between versions.
> Signed-off-by: Nickolai Kozachenko <daemongloom@xxxxxxxxx>
> ---
> Tested on my own device. Thanks to Alex Hung for creating quirk for
> Wacom MobileStudio devices that can be reused for HP Spectre X2 (2015).
>
> --- drivers/platform/x86/intel-hid.c.orig 2020-05-29
> 13:13:43.768032597 +0500
> +++ drivers/platform/x86/intel-hid.c 2020-05-29 13:19:30.089899469 +0500
> @@ -79,6 +79,13 @@ static const struct dmi_system_id button
> DMI_MATCH(DMI_PRODUCT_NAME, "Wacom MobileStudio Pro 16"),
> },
> },
> + {
> + .ident = "HP Spectre x2 (2015)",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x2 Detachable"),
> + },
> + },
> { }
> };
>
--
With Best Regards,
Andy Shevchenko
