On Thu, 14 May 2020 at 08:16, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, May 13, 2020 at 11:18:15PM +0100, Emil Velikov wrote: > > Hi Greg, > > > > On Fri, 2 Aug 2019 at 11:46, Greg Kroah-Hartman > > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > I have now done this with patch 1/10. Here's the pull info if any > > > subsystem maintainer wants to suck this into their tree to provide the > > > ability for drivers to add/remove attribute groups easily. > > > > > > This is part of my driver-core tree now, and will go to Linus for > > > 5.4-rc1, along with a few platform drivers that have been acked by their > > > various subsystem maintainers that convert them to use this new > > > functionality. > > > > > > If anyone has any questions about this, please let me know. > > > > > > thanks, > > > > > > greg k-h > > > > > > ------------------- > > > > > > The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: > > > > > > Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/dev_groups_all_drivers > > > > > > for you to fetch changes up to 23b6904442d08b7dbed7622ed33b236d41a3aa8b: > > > > > > driver core: add dev_groups to all drivers (2019-08-02 12:37:53 +0200) > > > > > > ---------------------------------------------------------------- > > > dev_groups added to struct driver > > > > > > Persistent tag for others to pull this branch from > > > > > > This is the first patch in a longer series that adds the ability for the > > > driver core to create and remove a list of attribute groups > > > automatically when the device is bound/unbound from a specific driver. > > > > > > See: > > > https://lore.kernel.org/r/20190731124349.4474-2-gregkh@xxxxxxxxxxxxxxxxxxx > > > for details on this patch, and examples of how to use it in other > > > drivers. > > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > > > ---------------------------------------------------------------- > > > Dmitry Torokhov (1): > > > driver core: add dev_groups to all drivers > > > > > > drivers/base/dd.c | 14 ++++++++++++++ > > > include/linux/device.h | 3 +++ > > > 2 files changed, 17 insertions(+) > > > _______________________________________________ > > > > Was planning to re-spin DRM a series which uses .dev_groups, although > > I cannot see the core patch. > > Did the it get reverted or simply fell though the cracks? > > Nope, it's in there: > 23b6904442d0 ("driver core: add dev_groups to all drivers") > which showed up in the 5.4 kernel release. > > Lots of other subsystems have already been converted to use this, do you > not see it in your tree? > A case of PEBKAC it seems - I was looking at a 5.3 checkout somehow. Thanks for the core work. Will check/merge the fbdev patches over the next few days and polish drm land. -Emil