On Wed, May 6, 2020 at 3:16 PM <malattia@xxxxxxxx> wrote:
>
> From: Mattia Dongili <malattia@xxxxxxxx>
>
> The thermal handle object may fail initialization when the module is
> loaded in the first place. Avoid attempting to use it on resume then.
>
The patches require prefix, "platform/x86: sony-laptop: ".
I fixed for now.
> Fixes: 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer objects for ASL create_field() operator")
> Reported-by: Dominik Mierzejewski <dominik@xxxxxxxxxxxxxx>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=207491
> Signed-off-by: Mattia Dongili <malattia@xxxxxxxx>
> ---
> drivers/platform/x86/sony-laptop.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index 425707e8d188..2ec115f378b2 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -2278,7 +2278,12 @@ static void sony_nc_thermal_cleanup(struct platform_device *pd)
> #ifdef CONFIG_PM_SLEEP
> static void sony_nc_thermal_resume(void)
> {
> - unsigned int status = sony_nc_thermal_mode_get();
> + int status;
> +
> + if (!th_handle)
> + return;
> +
> + status = sony_nc_thermal_mode_get();
>
This line is redundant. But I fixed when applied.
Nevertheless, see comments to patch 1, which needs more work.
> if (status != th_handle->mode)
> sony_nc_thermal_mode_set(th_handle->mode);
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
