Re: [PATCH 2/2] [sony-laptop] Don't use thermal handle if NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 5, 2020 at 4:17 PM Mattia Dongili <malattia@xxxxxxxx> wrote:
> On Tue, May 05, 2020 at 03:38:15PM +0300, Andy Shevchenko wrote:
> > On Tue, May 5, 2020 at 1:16 PM <malattia@xxxxxxxx> wrote:
> > >
> > > From: Mattia Dongili <malattia@xxxxxxxx>
> > >
> > > The thermal handle object may fail initialization when the module is
> > > loaded the first time.
> > >
> >
> > But isn't it a papering over the real issue that it fails first time?
> > AFAIU user needs to try first time and if it fails to try again. Can
> > we rather understand the root cause first?
>
> I think this is a bug regardless of what ACPICA does.

I didn't speak about ACPICA.

> If the driver fails completing whatever initialization, should it not
> avoid dereferencing a NULL pointer on resume?

Yes, but *why* it fails?

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux