Do you have a use case for that behavior? The previous patch broke the /proc interface, didn't not work with the current version of thinkfan (but a a version with multi-fan support is in the works), and it had hard to track internal mutable state. The proposed change is clean on all these fronts. I'm not a fan of surprising the user with unnecessarily complex behavior (but perhaps this can be added as an option in the future.) -- Lars On Tuesday, April 28, 2020, 2:18:42 PM PDT, civic9 <civic9@xxxxxxxxx> wrote: pon., 27 kwi 2020 o 20:41 Dario Messina <nanodario@xxxxxxxxx> napisał(a): > > On Thu, Apr 23, 2020 at 23:57:59 CEST, Lars <larsh@xxxxxxxxxx> wrote: > > This adds dual fan control for the following models: > > P50, P51, P52, P70, P71, P72, P1 gen1, X1E gen1, P2 gen2, and X1E gen2. > > > > Both fans are controlled together as if they were a single fan. > > [...] > > Background: > > I tested the BIOS default behavior on my X1E gen2 and both fans are always > > changed together. So rather than adding controls for each fan, this controls > > both fans together as the BIOS would do. > Hi Lars, why have you chosen to control multiple fans in this way? > I know that BIOS controls both fans together, but the EC has the capabilities > to control both fans independently, so maybe it can be convenient to expose > this feature. +1 Previous version of the patch [1] allows to control both fans independently. However some software like thinkfan is not ready to control two fans. But I also think this feature should be at least optionally exposed. [1] https://github.com/civic9/thinkpad_acpi.2ndfan.patch/blob/master/thinkpad_acpi.2ndfan.patch/thinkpad_acpi.2ndfan.patch
