Hi Dario, it just seemed an unnecessary complication for the user. This way existing tools (like thinkfan) would just continue to work. I could not think of any use case on these laptops where you actually want to control the fan independently. It would also be hard to expose this through the /proc/acpi/ibm/fan interface. -- Lars On Monday, April 27, 2020, 11:41:22 AM PDT, Dario Messina <nanodario@xxxxxxxxx> wrote: On Thu, Apr 23, 2020 at 23:57:59 CEST, Lars <larsh@xxxxxxxxxx> wrote: > This adds dual fan control for the following models: > P50, P51, P52, P70, P71, P72, P1 gen1, X1E gen1, P2 gen2, and X1E gen2. > > Both fans are controlled together as if they were a single fan. > [...] > Background: > I tested the BIOS default behavior on my X1E gen2 and both fans are always > changed together. So rather than adding controls for each fan, this controls > both fans together as the BIOS would do. Hi Lars, why have you chosen to control multiple fans in this way? I know that BIOS controls both fans together, but the EC has the capabilities to control both fans independently, so maybe it can be convenient to expose this feature. Distinti saluti/Best regards, Dario Messina
