On Wed, Apr 8, 2020 at 6:36 AM Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> wrote: > > On Wed, 2020-04-08 at 10:42 +0800, Jason Yan wrote: > > Fix the following sparse warning: > > > > drivers/platform/x86/intel-uncore-frequency.c:56:16: warning: symbol > > 'uncore_root_kobj' was not declared. Should it be static? > > > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> > Pushed to my review and testing queue, thanks! > > --- > > drivers/platform/x86/intel-uncore-frequency.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/platform/x86/intel-uncore-frequency.c > > b/drivers/platform/x86/intel-uncore-frequency.c > > index b96d172eb2c1..12d5ab7e1f5d 100644 > > --- a/drivers/platform/x86/intel-uncore-frequency.c > > +++ b/drivers/platform/x86/intel-uncore-frequency.c > > @@ -53,7 +53,7 @@ static int uncore_max_entries __read_mostly; > > /* Storage for uncore data for all instances */ > > static struct uncore_data *uncore_instances; > > /* Root of the all uncore sysfs kobjs */ > > -struct kobject *uncore_root_kobj; > > +static struct kobject *uncore_root_kobj; > > /* Stores the CPU mask of the target CPUs to use during uncore > > read/write */ > > static cpumask_t uncore_cpu_mask; > > /* CPU online callback register instance */ > -- With Best Regards, Andy Shevchenko