On Thu, Apr 2, 2020 at 10:16 AM YueHaibing <yuehaibing@xxxxxxxxxx> wrote: > > Fix sparse warnings: > > drivers/platform/x86/xiaomi-wmi.c:26:5: warning: symbol 'xiaomi_wmi_probe' was not declared. Should it be static? > drivers/platform/x86/xiaomi-wmi.c:51:6: warning: symbol 'xiaomi_wmi_notify' was not declared. Should it be static? > Pushed to my review and testing queue, thanks! > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > --- > drivers/platform/x86/xiaomi-wmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiaomi-wmi.c > index 601cbb282f54..54a2546bb93b 100644 > --- a/drivers/platform/x86/xiaomi-wmi.c > +++ b/drivers/platform/x86/xiaomi-wmi.c > @@ -23,7 +23,7 @@ struct xiaomi_wmi { > unsigned int key_code; > }; > > -int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context) > +static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context) > { > struct xiaomi_wmi *data; > > @@ -48,7 +48,7 @@ int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context) > return input_register_device(data->input_dev); > } > > -void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy) > +static void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy) > { > struct xiaomi_wmi *data; > > -- > 2.17.1 > > -- With Best Regards, Andy Shevchenko