On Tue, Feb 11, 2020 at 05:57:06PM +0200, Andy Shevchenko wrote: > On Tue, Feb 11, 2020 at 04:25:54PM +0300, Mika Westerberg wrote: > > Both PMIC drivers (intel_soc_pmic_mrfld and intel_soc_pmic_bxtwc) will > > be using this field going forward to access the SCU IPC instance. > > > > While there add kernel-doc for the intel_soc_pmic structure. > > > + * @irq_chip_data_pwrbtn: Chained IRQ chip data for the power button > > + * @irq_chip_data_tmu: Chained IRQ chip data for the time management unit > > + * @irq_chip_data_bcu: Chained IRQ chip data for the burst control unit > > + * @irq_chip_data_adc: Chained IRQ chip data for the general purpose ADC > > + * @irq_chip_data_chgr: Chained IRQ chip data for the external charger > > + * @irq_chip_data_crit: Chained IRQ chip data for the critical event handler > > Perhaps capitalize the decoded abbreviation, e.g. > general purpose ADC -> General Purpose ADC ? Sure.
