On Wed, Jan 22, 2020 at 02:46:21PM +0100, Greg Kroah-Hartman wrote: > > if (ret) { > > dev_err(pmic->dev, "Failed to read from PMIC\n"); > > Meta-comment, the call should be the thing making that error message, > do not force all callers to log it again, or in some other way. That > just makes for a larger mess. OK, I'll do that.